Repository navigation
feat(popups): server popups over the root navigator, configurable UI theme - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PersonalizationInAppPopupover the app's root navigator — after the delay set in the admin, one at a time, a repeat within a minute dropped.onPopuptakes them instead;tracking.popupShownandpresentPopupgo with it.PersonalizationTheme.configure(brand colours per scheme, font, radii) andPersonalizationTheme.mode(follow the app or fixed light/dark), in MaterialApp and CupertinoApp alike; the ThemeExtension route is gone.InAppPopup,PersonalizationInAppPopupand the theme types; the rest of the kit stays internal.Android SDK v2.45.0: popups shown on launch reach Android (rees46/android-sdk#226).